qwik icon indicating copy to clipboard operation
qwik copied to clipboard

[🐞] trying to build qwik on windows throws

Open shairez opened this issue 3 years ago • 4 comments

Which component is affected?

Starters / CLI

Describe the bug

When trying to build qwik I'm getting the following error:

image

seems like it's trying to go to the runtime dir on the root of the monorepo and not inside qwik city

Reproduction

not relevant

Steps to reproduce

  1. pnpm install
  2. pnpm build.platform.copy
  3. pnpm build

System Info

System:
    OS: Windows 10 10.0.19044
    CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
    Memory: 12.78 GB / 31.87 GB
  Binaries:
    Node: 18.7.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.10 - C:\Program Files\nodejs\yarn.CMD
    npm: 8.15.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 106.0.5249.121
    Edge: Spartan (44.19041.1266.0), Chromium (108.0.1462.54), ChromiumDev (Hello HiRez.io!)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    @builder.io/partytown: 0.7.3 => 0.7.3
    vite: 4.0.1 => 4.0.1

Additional Information

No response

shairez avatar Dec 24 '22 14:12 shairez

OK this happens only when using "pnpm"

If I go to packages/qwik-city and run pnpm build I get the same error (that it can't find the "runtime" folder)

But when I run npm run build on the same folder, it passes 🤷‍♂️

shairez avatar Dec 24 '22 21:12 shairez

this is the problematic line - https://github.com/BuilderIO/qwik/blob/main/scripts/qwik-city.ts#L155

if I change this to

const result = await execa('npm', ['run', 'build'], {

it works...

shairez avatar Dec 24 '22 21:12 shairez

Just reporting in to say I have the same problem still (thanks to @n8sabes for pointing this issue out to me).

I'm actually getting a Linux VM set up right now as I type this just so I can start actively contributing to the code base 😂 Any fix here would be greatly appreciated

KenAKAFrosty avatar Mar 20 '23 23:03 KenAKAFrosty

@shairez what was the line you changed to get it to work?

adamdbradley avatar May 12 '23 19:05 adamdbradley

@adamdbradley https://github.com/BuilderIO/qwik/blob/main/scripts/qwik-city.ts#L184

shairez avatar May 15 '23 08:05 shairez

Currently experiencing this issue as well using windows 11 and seems to be happening to all windows users

thejackshelton avatar Jun 26 '23 19:06 thejackshelton

I tried this change https://github.com/BuilderIO/qwik/pull/4777/files and it works. But I'm not sure if is the best way...

leifermendez avatar Jul 11 '23 08:07 leifermendez

fixed by #4777

Thanks again @leifermendez ! 🙏

shairez avatar Jul 17 '23 20:07 shairez