qwik icon indicating copy to clipboard operation
qwik copied to clipboard

qwik-solid integration (WIP)

Open voluntadpear opened this issue 3 years ago • 2 comments

What is it?

  • [x] Feature / enhancement
  • [ ] Bug
  • [ ] Docs / tests

Description

Qwikifying Solid.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • [ ] My code follows the developer guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

voluntadpear avatar Nov 27 '22 00:11 voluntadpear

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Google API Key 8d5b01fc1dceac7b5f45b95cae2d7fe9944d06fc packages/docs/scripts/showcase.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Jan 08 '23 00:01 gitguardian[bot]

Hello, is there any ETA for this integration? I am eagerly looking forward to it.

Dindaleon avatar Feb 15 '23 07:02 Dindaleon

Are you still working on this feature? Do you need any help?

gioboa avatar Aug 24 '23 10:08 gioboa

hi @voluntadpear thanks for your commitment and for this amazing piece of work. The best option for this kind of integration is:


Have a community organization

  • Have a https://github.com/QwikDev organization that can publish to @qwikdev/____ The nice part of the org is that it still has the "seal" of Qwik without passing on the cost to the Qwik core maintainers.
  • This way, the core Qwik team is not on the hook to support the feature long time (as most of the time, they are not the experts)
  • Qwik core team is not involved in having to review the PR and make a judgment call if the quality is good enough (given that hey are not the experts in that area)

I will close this PR, thanks again for your awesome job.

gioboa avatar Oct 10 '23 20:10 gioboa