ceremonyclient
ceremonyclient copied to clipboard
Upgrade pebble dependencies and fix tests
A major dependencies bump and update to go 1.24 (already in use by the node) while ensuring all tests succeed.
- The only remaining challenge is the
linttests some of which install tools likestaticcheckandgolintduring runtime. This causes the addition of the dependencies to the pebble's rootgo.modupon execution. However, after execution the IDE tools suggest that the addedgo.moddependencies are unnecessary. I checked the original pebble repo and it seems like they're trying to localize these runtime deps in a separateinternal/devtoolsdir with its owngo.mod. However, cloning the original pebble repo I cannot get the lint tests to succeed. So some advice here would be appreciated. - Another question is that this is the only module with the original project path instead of Q-specific one. I am not sure if that needs to be changed or not. I also added a
replacein thego.modpointing to our module's local path, please validate if that is something useful. - Last, but not least, it seems there are many changes in the original pebble project. I suppose our pebble fixes made our fork rather incompatible, meaning it makes little sense to merge upstream changes. However, a confirmation on this point would be useful.
- I still need to upgrade
zstd