QuickBirdEng
Can't run on Flutter 2.8, Flutter 2.5, and Flutter 2.2
Hi friends!
Reference to the appropriate PR #3 .
Guys, having read the next Flutter article https://quickbirdstudios.com/blog/flutter-adaptive-search-widget/ I was curious to try it out. Unfortunately, I couldn't run flutter_platform_search on my emulator.
The issue reproduces on the stable Flutter 2.8.1, Flutter 2.5.3, and Flutter 2.2.x (2.2.3, 2.2.0) releases.
Below the run output:
I am looking to use this very soon. Will it be fixed? This repo looks amazing.
Hi Servon Lewis,
I think that I finished my fixes and provided the completed PR. And my comments are below.
The flutter_platform_search demo with my PR will run on Flutter >=2.8.0. *Flutter 2.8.0 *has been released on Dec 8, 2021. The current version is
- 2.8.1* Please, run the demo to check that things are going well also and at your device(s). I have modified only the part that utilizes the fluent_ui library. On Android and iOS, the flutter_platform_search demo works well as it worked and before.
I think that most of the developers (not all of course) have been updated their Flutter to the latest 2.8.0 or 2.8.1 versions. If not, when they will find that they should upgrade their SDK to run the demo. It's okay.
Especially, flutter_platform_search is a demo for educational and portfolio purposes and there is no strong restriction to be compatible with old Flutter 2.2 and Flutter 2.5 releases. Just we can mention in README.md that the project has been updated to work Flutter 2.8 and above.
Or we have to fork the fluent_ui repo and fix the bug that occurs in the library running on Flutter 2.2 and above. To use the fixed fork then at flutter_platform_search.
But again, if we will consider the current code of the flutter_platform_search that runs on Flutter 2.0, I found there are a couple of UI issues that reproduced at least on my Android when I tried to run it on Flutter 2.0.
Servon, if there are some doubts, thoughts, questions on my PR, let's discuss. I'm open to hearing and happy to help.
On Sat, Jan 29, 2022 at 12:51 AM Servon Lewis @.***> wrote:
I am looking to use this very soon. Will it be fixed? This repo looks amazing.
— Reply to this email directly, view it on GitHub https://github.com/quickbirdstudios/flutter_platform_search/issues/1#issuecomment-1024825420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AML5T74HUNVZP4AVQBLQCGDUYNP3XANCNFSM5MFZOQWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
Hi Servon Lewis,
I think that I finished my fixes and provided the completed PR. And my comments are below.
The flutter_platform_search demo with my PR will run on Flutter >=2.8.0. *Flutter 2.8.0 *has been released on Dec 8, 2021. The current version is
- 2.8.1* Please, run the demo to check that things are going well also and at your device(s). I have modified only the part that utilizes the fluent_ui library. On Android and iOS, the flutter_platform_search demo works well as it worked and before.
I think that most of the developers (not all of course) have been updated their Flutter to the latest 2.8.0 or 2.8.1 versions. If not, when they will find that they should upgrade their SDK to run the demo. It's okay.
Especially, flutter_platform_search is a demo for educational and portfolio purposes and there is no strong restriction to be compatible with old Flutter 2.2 and Flutter 2.5 releases. Just we can mention in README.md that the project has been updated to work Flutter 2.8 and above.
Or we have to fork the fluent_ui repo and fix the bug that occurs in the library running on Flutter 2.2 and above. To use the fixed fork then at flutter_platform_search.
But again, if we will consider the current code of the flutter_platform_search that runs on Flutter 2.0, I found there are a couple of UI issues that reproduced at least on my Android when I tried to run it on Flutter 2.0.
Servon, if there are some doubts, thoughts, questions on my PR, let's discuss. I'm open to hearing and happy to help.
On Sat, Jan 29, 2022 at 12:51 AM Servon Lewis @.***> wrote:
I am looking to use this very soon. Will it be fixed? This repo looks amazing.
— Reply to this email directly, view it on GitHub https://github.com/quickbirdstudios/flutter_platform_search/issues/1#issuecomment-1024825420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AML5T74HUNVZP4AVQBLQCGDUYNP3XANCNFSM5MFZOQWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
Thank you. I will give it a shot within a week or two! I was just looking into this repo, as I know I will need to implement something like this very soon. I appreciate it
What's the recommended way to use this? Just copy the code? Or is there a way to use it as a library? I don't think I see this on pub.dev
Hi Servon!
You can merge my PR directly to the project.
Just open my Pull Request https://github.com/quickbirdstudios/flutter_platform_search/pull/3 And find there the "Merge pull request" button (scroll the page to find the green button). (Here is more information on how to apply Pull Requests https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request )
Regards, Max
On Wed, Feb 9, 2022, 1:13 AM Servon Lewis @.***> wrote:
What's the recommended way to use this? Just copy the code? Or is there a way to use it as a library?
— Reply to this email directly, view it on GitHub https://github.com/quickbirdstudios/flutter_platform_search/issues/1#issuecomment-1033327446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AML5T77QKUVESSTJ6PQR2RDU2HSV3ANCNFSM5MFZOQWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>