Quaver.API icon indicating copy to clipboard operation
Quaver.API copied to clipboard

Use bit manipulation instead of arithmetic subtraction for generating perfect replay releases

Open WilliamQiufeng opened this issue 1 year ago • 0 comments

Opera Skaala - Heart of Light - 29686.zip

In this map (SM convert), some notes overlap so it messes up the perfect replay. This map spams this error:

System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at System.Collections.Generic.List`1.set_Item(Int32 index, T value)
   at Quaver.Shared.Screens.Gameplay.Rulesets.Input.ReplayInputManagerKeys.HandleInput(Boolean forceInput) in D:\RiderProjects\QuaverCanary\Quaver.Shared\Screens\Gameplay\Rulesets\Input\ReplayInputManagerKeys.cs:line 142

Which is due to the use of arithmetic subtraction, instead of bit manipulation, of press state.

This PR resolves this issue

WilliamQiufeng avatar May 08 '24 00:05 WilliamQiufeng