RedReader icon indicating copy to clipboard operation
RedReader copied to clipboard

"Load more comments" is slow

Open buildist opened this issue 6 years ago • 3 comments

Been using RedReader for years, and the only reason I have the official app installed is for comment-heavy posts like those found in r/AskReddit. In RR it seems like it's sending one request per comment instead of one request for the whole page, and the result is every single comment instead of the highest voted like you'd see in the official app.

buildist avatar Aug 27 '19 06:08 buildist

Thanks for the report. This is deliberate -- we do request the extra comment trees one-by-one (one request for every top-level comment).

At the time when this was implemented, the preferred API to do this (in a single request) was unreliable and would sometimes just not return at all. I don't know if this is still the case today, although I do sometimes see "more comment" requests taking an excessive amount of time (10 seconds or more) on the desktop site. It's worth looking into switching to the better API and comparing the two approaches.

QuantumBadger avatar Oct 04 '19 15:10 QuantumBadger

still relevant, perhaps load intelligently , i.e. load first fee comments slow and reliable, then try in batches?

marcel263 avatar Jan 26 '22 21:01 marcel263

Thanks for the report. This is deliberate -- we do request the extra comment trees one-by-one (one request for every top-level comment).

At the time when this was implemented, the preferred API to do this (in a single request) was unreliable and would sometimes just not return at all. I don't know if this is still the case today, although I do sometimes see "more comment" requests taking an excessive amount of time (10 seconds or more) on the desktop site. It's worth looking into switching to the better API and comparing the two approaches.

Thanks for the reply. Comments still load 1 by 1 after clicking load more comments. Other reddit apps don't have this issue, I think they load ALL comments at once, then locally collapse the nested ones, as they seem to expand and appear instantly when you expand them in other apps. Try this @QuantumBadger ? The less API calls the better! It doesn't appear to be unreliable now.

immolated1 avatar Aug 11 '23 21:08 immolated1