glum icon indicating copy to clipboard operation
glum copied to clipboard

Daily run failure: Unit tests

Open github-actions[bot] opened this issue 1 year ago • 5 comments

The daily unit tests failed. See https://github.com/Quantco/glum/actions/runs/8578861406 for details.

github-actions[bot] avatar Apr 06 '24 05:04 github-actions[bot]

I believe the reason for the nightly failure is this deprecation came into effect in pandas 3.0.0dev0:

stanmart avatar Apr 06 '24 09:04 stanmart

I think I managed to reproduce it:

import pandas as pd

pd.SparseDtype(bool, fill_value=0)

after installing the nightly version of pandas raises ValueError: fill_value must be a valid value for the SparseDtype.subtype. See also changes to test_array here. So fill_value in https://github.com/Quantco/tabmat/blob/0e22f477e134cf119789eab8279f5abf2b5b193a/src/tabmat/constructor.py#L111 should be changed to False for Booleans.

@MatthiasSchmidtblaicherQC now that your PR is merged this can be closed, right?

stanmart avatar May 17 '24 18:05 stanmart

The daily tests are still failing, but for different reasons: https://github.com/Quantco/glum/actions/runs/9153751283/job/25163209834

lbittarello avatar May 20 '24 08:05 lbittarello

Oh I see. #792 should fix the test_formula failures. The rest are due to scipy removing the .A shorthand for toarray(), and need to be fixed in tabmat.

stanmart avatar May 21 '24 09:05 stanmart

fixed with tabmat #361

MarcAntoineSchmidtQC avatar May 24 '24 15:05 MarcAntoineSchmidtQC