rustworkx icon indicating copy to clipboard operation
rustworkx copied to clipboard

Add Python 3.13 to CI and to release

Open IvanIsCoding opened this issue 1 year ago • 6 comments

This adds Python 3.13 to CI and bumps cibuildwheel to the latest version.

I will test the wheel build on my personal repository before merging.

IvanIsCoding avatar Oct 04 '24 22:10 IvanIsCoding

Putting this on hold until October 7

IvanIsCoding avatar Oct 05 '24 03:10 IvanIsCoding

Pull Request Test Coverage Report for Build 11769405948

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.825%

Totals Coverage Status
Change from base Build 11709175986: 0.0%
Covered Lines: 18016
Relevant Lines: 18801

💛 - Coveralls

coveralls avatar Oct 08 '24 16:10 coveralls

And we are affected by https://github.com/python-pillow/Pillow/issues/6676, MyPy is getting smarter although not when I wanted

IvanIsCoding avatar Oct 09 '24 02:10 IvanIsCoding

This LGTM, but before merging we probably should update the trove classifiers in the setup.py: https://github.com/Qiskit/rustworkx/blob/main/setup.py#L72

I added 3.13 to that list. I also just removed win32 from the wheels being built because of #1293. I will test the wheels build in my repository before merging.

IvanIsCoding avatar Oct 14 '24 17:10 IvanIsCoding

The test build is running at https://github.com/IvanIsCoding/rustworkx/actions/runs/11332447391.

IvanIsCoding avatar Oct 14 '24 17:10 IvanIsCoding

The test build passed, all the failures are permission issues because we omitted the PyPI tokens. This is good to go

IvanIsCoding avatar Oct 14 '24 20:10 IvanIsCoding

After the NumPy bump in #1305 we no longer need to drop the Windows 32-bit build. All builds are working now

IvanIsCoding avatar Oct 31 '24 01:10 IvanIsCoding