rustworkx icon indicating copy to clipboard operation
rustworkx copied to clipboard

compute maximum bisimulation using Paige-Tarjan's Algorithm

Open sander-hergarten opened this issue 2 years ago • 4 comments

regarding #1075

sander-hergarten avatar Feb 15 '24 19:02 sander-hergarten

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 15 '24 19:02 CLAassistant

i had some trouble running tox -edocs on my machine. Please let me know if there are any issues with the documentation or release notes

sander-hergarten avatar Feb 15 '24 19:02 sander-hergarten

Pull Request Test Coverage Report for Build 9621638477

Details

  • 297 of 309 (96.12%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 95.868%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bisimulation.rs 294 296 99.32%
src/iterators.rs 0 10 0.0%
<!-- Total: 297 309
Totals Coverage Status
Change from base Build 9620550342: 0.005%
Covered Lines: 17886
Relevant Lines: 18657

💛 - Coveralls

coveralls avatar Feb 15 '24 23:02 coveralls

As a heads up, when reading "Three Partition Refinement Algorithms", I renamed a lot of the variables.

  • Blocks of Partition $X$: CoarseBlock
  • Blocks of Partition $Q$: FineBlock
  • $C$: queue
  • $S$: splitter_block Also while the authors say that blocks of $Q$ are contained in blocks of $X$ I interpreted this as the block of $Q$ being a subset of $X$. (I found this confusing so i thought i would mention it)

sander-hergarten avatar Feb 16 '24 00:02 sander-hergarten