documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Add SKQD tutorial

Open kevinsung opened this issue 9 months ago • 3 comments

Fixes #3003

kevinsung avatar Apr 16 '25 16:04 kevinsung

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@miamico

nathanearnestnoble avatar Apr 29 '25 19:04 nathanearnestnoble

Thanks Kevin! I think it is fairly solid, some minor feedback:

  • I think it would be useful to reference our Krylov tutorial as well, in case people want to gain a deeper understand of the specifics around it
  • @miamico made a good point that I wanted to raise: As you are specifically using the impurity anderson hamiltonian from the paper, you need to introduce an additional step of changing from position basis to momentum basis. I think there could be a benefit to have two component to the tutorial: a simpler hamitlonian that does not require this mapping because it is already sparse, and then a second "more advanced" part II highlight the specific step of basis change to overcome the issue of having a non-sparse matrix and is brief on other elements of the workflow already discussed.

nathanearnestnoble avatar May 01 '25 16:05 nathanearnestnoble

@kevinsung Thanks! I left some comments via the ReviewNB app here.

@jenglick I just updated the PR to use the new diagonalize_fermionic_hamiltonian funtion and then went to revisit your comments, but this is what I see when I click the link: image

kevinsung avatar Jun 06 '25 01:06 kevinsung

This looks great! Just a couple comments

  • I think we should also refer to the KQD paper (and tutorial) as the convergence guarantee of the unitary krylov subspace are detailed there
  • could you add a "Reference" section where the various sources (SQD, KQD, SKQD paper) are listed?

miamico avatar Jun 09 '25 20:06 miamico

This looks great! Just a couple comments

* I think we should also refer to the [KQD paper ](https://arxiv.org/abs/2407.14431)(and [tutorial](https://quantum.cloud.ibm.com/docs/en/tutorials/krylov-quantum-diagonalization)) as the convergence guarantee of the unitary krylov subspace are detailed there

* could you add a "Reference" section where the various sources (SQD, KQD, SKQD paper) are listed?

Done

kevinsung avatar Jun 13 '25 15:06 kevinsung