documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Refactor Krylov tutorial

Open frankharkins opened this issue 1 year ago • 9 comments

This tutorial was originally created in IBM-Quantum-Technical-Enablement/quantum-enablement#11. Part of #1166.

frankharkins avatar May 09 '24 09:05 frankharkins

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 09 '24 09:05 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 09 '24 09:05 CLAassistant

Maybe we need a blocklist mechanism for notebooks that completely fail? It'd be best to not try to fix the notebook in this PR, but we also don't want CI to be red.

Eric-Arellano avatar May 09 '24 13:05 Eric-Arellano

I think @abbycross will be working on this branch, so we can fix it in this PR

frankharkins avatar May 09 '24 16:05 frankharkins

Hi @miamico! I've gone through to do voice/style edits on this tutorial, and am trying to run the notebook. The code throws an error in Step 3 - can you see what's going on?

abbycross avatar May 14 '24 16:05 abbycross

Hi @miamico! I've gone through to do voice/style edits on this tutorial, and am trying to run the notebook. The code throws an error in Step 3 - can you see what's going on?

Is it that the notebook is using 11 qubits? We're trying to run this notebook with our 5-qubit simulator in CI, but if it requires 11 qubits, that won't work. If this notebook can't be rewritten to work with the 5-qubit simulator, then we need to update notebooks.toml to move it from notebooks_that_submit_jobs to instead notebooks_no_mock. It's desirable to allow us to mock it if possible so that we get more CI validation.

Eric-Arellano avatar May 14 '24 19:05 Eric-Arellano

I'm working on a version of this notebook that will be using the hardware at utility scale. I'd hold off any further work on this version based on the simulator

miamico avatar May 16 '24 15:05 miamico

I'm working on a version of this notebook that will be using the hardware at utility scale. I'd hold off any further work on this version based on the simulator

@miamico ok thanks!!

abbycross avatar May 16 '24 15:05 abbycross

This is continued in inner-source.

frankharkins avatar Jul 16 '24 15:07 frankharkins