POT icon indicating copy to clipboard operation
POT copied to clipboard

The example in the tutorial (Optimal Transport solvers comparison) does not work due to the NotImplementedError

Open RequieMa opened this issue 1 year ago • 1 comments

I tried the example in Optimal Transport solvers comparison (https://pythonot.github.io/auto_examples/plot_solve_variants.html#sphx-glr-auto-examples-plot-solve-variants-py)

It gave me NotImplementedError when defining G = ot.solve(M, a, b, **param).plan

NotImplementedError: Not implemented reg_type="KL" and unbalanced_type="tv"

By inspecting the code, it seems that many combinations are ignored in the implementation. https://github.com/PythonOT/POT/blob/ea841c729439e9ffab75fe3851d0afd977dfbb1d/ot/solvers.py#L395

Will that be included in future? Or does it exist in some branches? (I installed via pip install POT[all], and it seems to installed POT-0.9.3-cp38-cp38-win_amd64.whl)

RequieMa avatar Oct 31 '24 09:10 RequieMa

The ot solver comparisaon was introduced in 0.9.4 so your version is out of date. This isa goodfeedback we should probably add "Introduce in POT X.X.X" to the new examples in the documentation

rflamary avatar Nov 18 '24 07:11 rflamary

Closing this Issue it has been fixed in PR #743

rflamary avatar Aug 13 '25 14:08 rflamary