pycardano icon indicating copy to clipboard operation
pycardano copied to clipboard
verified publisher icon Python-Cardano

cardano-cli ChainContext impl

Open thaddeusdiamond opened this issue 2 years ago • 5 comments

For those running a local cardano-node, using Python os.system() calls to shell out to cardano-cli and submit transactions/read from chain could be interesting. Let me know if you would like a pull request for this, I can try to stub one out. Just didn't want to proceed with coding if you had a good reason not to do this default impl in the library.

thaddeusdiamond avatar Jun 02 '23 02:06 thaddeusdiamond

I was thinking the same. Maybe check that all functions of the chaincontext can actually be implemented by the CLI, but I think it should work and would improve the library a lot :)

nielstron avatar Jun 02 '23 05:06 nielstron

I think it is a good idea to expand the support of chain context in general. With that being said, I am not sure how stable the output of cardano-cli is. If it changes often, it means we will need to update pycardano accordingly as well.

cffls avatar Jun 03 '23 23:06 cffls

From my experience the output of cardano-cli has been pretty stable over the last 1.5 years. It should be fine to build on top of.

nielstron avatar Jun 29 '23 12:06 nielstron

I added the cardano-cli chain context and submitted a pull request here #274.

The added code has tests as well, but I did not add any extra documentation yet.

KINGH242 avatar Oct 08 '23 12:10 KINGH242

Thanks! It looks really clean, well done. Sorry I didn't get a chance to get to it in time.

thaddeusdiamond avatar Oct 08 '23 22:10 thaddeusdiamond

Closing, since #274 has been merged

nielstron avatar Apr 11 '24 15:04 nielstron