Removed the duplicated ENV vars in the deployment template, as this prevents argocd etc from creating the deployment.

[johnhomelan]

There are a number of duplicated ENV vars passed to the pod created by the Deployment. This prevents deployment tools e.g. Argocd from creating the deployment, as pods are not supposed to have duplicate ENV vars. This pull request removes the duplicates

e.g. Failed sync attempt to : one or more objects failed to apply, reason: failed to create typed patch object (calcom/calcom-stack; apps/v1, Kind=Deployment): errors: .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="EMAIL_SERVER_HOST"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="EMAIL_SERVER_PASSWORD"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="EMAIL_SERVER_PORT"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="EMAIL_SERVER_USER"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="CALENDSO_ENCRYPTION_KEY"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="DATABASE_DIRECT_URL"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="DATABASE_URL"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="EMAIL_SERVER_HOST"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="EMAIL_SERVER_PORT"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="GOOGLE_API_CREDENTIALS"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="GOOGLE_LOGIN_ENABLED"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="NEXTAUTH_SECRET"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="NEXT_PUBLIC_DISABLE_SIGNUP"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="NEXT_PUBLIC_HOSTED_CAL_FEATURES"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="NEXT_PUBLIC_WEBAPP_URL"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="PGSSLMODE"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="PRISMA_GENERATE_DATAPROXY"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="SAML_ADMINS"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="SAML_DATABASE_URL"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="STRIPE_CLIENT_ID"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="STRIPE_PRIVATE_KEY"] .spec.template.spec.containers[name="calcom"].env: duplicate entries for key [name="STRIPE_WEBHOOK_SECRET"]

Summary by CodeRabbit

• Bug Fixes
  • Streamlined environment variable configuration by removing several deprecated variables to enhance deployment stability and security.
• Documentation
  • Updated deployment configuration notes to reflect recent changes in environment variable declarations.

[coderabbitai[bot]]

Walkthrough

The recent changes involve a significant reduction in environment variables within the deployment.yaml configuration file. Several key variables related to services such as email, authentication, and payment processing have been removed. This streamlining indicates a potential refactoring aimed at simplifying the deployment process and enhancing security by minimizing unnecessary exposure of sensitive information.

Changes

File Path	Change Summary
charts/calcom/templates/deployment.yaml	Removed multiple environment variables related to email, authentication, database, and payment services, including EMAIL_SERVER_HOST, DATABASE_DIRECT_URL, and STRIPE_CLIENT_ID.

Poem

In the patchwork of code, we trim and we mend,
A lighter deployment, where old troubles end.
With variables few, our path is now clear,
A hop towards the future, with less to fear!
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Pyrrha]

Hello @johnhomelan,

Thanks for your contribution, I'll merge it and release it right away. It's a real pain for me to maintain those variables, I'll fix my local script to make them uniques.

A future improvement could be to update these with a cron CI or something and release a minor update.