Pyhiveapi icon indicating copy to clipboard operation
Pyhiveapi copied to clipboard

[BUG] setBoostOn comparison error

Open amarnagi opened this issue 3 years ago • 3 comments

Describe the bug mins and temp data types cannot be used in comparsion ( i get an error) - mins is a str for example if mins > 0 and temp >= self.getMinTemperature(device):

Expected behavior I had to add this to fix it if int(mins) > 0 and int(temp) >= self.getMinTemperature(device): and if int(temp) <= self.getMaxTemperature(device):

amarnagi avatar Nov 07 '22 18:11 amarnagi

same issue on the hotwater.

python3.10/site-packages/pyhiveapi/hotwater.py", line 154, in setBoostOn mins > 0 TypeError: '>' not supported between instances of 'str' and 'int'

amarnagi avatar Nov 07 '22 18:11 amarnagi

Are you using the library with home assistant or on its own?

KJonline avatar Nov 07 '22 20:11 KJonline

@KJonline on it's own

amarnagi avatar Nov 07 '22 21:11 amarnagi