pycord icon indicating copy to clipboard operation
pycord copied to clipboard

Add support for Select Menus in Modals

Open NeloBlivion opened this issue 3 years ago • 2 comments

Summary

"Implements" select menus in modals (it was basically done already, just had to adjust refresh_state and type checking) This isn't the neatest PR in terms of implementation; it does the job, but as Discord potentially adds more features to modals it may be ideal to have a new class to manage further modal children types.

Checklist

  • [x] If code changes were made then they have been tested.
    • [x] I have updated the documentation to reflect the changes.
  • [ ] If type: ignore comments were used, a comment is also left explaining why
  • [ ] This PR fixes an issue.
  • [ ] This PR adds something new (e.g. new method or parameters).
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

NeloBlivion avatar Jun 14 '22 00:06 NeloBlivion

On hold till modal selects are released.

Selects for modals are only unofficially implemented in discord rn, it crashes old apps and on phone don't even render.

Lulalaby avatar Jun 14 '22 00:06 Lulalaby

Small update on this, a Discord admin claimed this was a bug and hence this was disabled on the API side. We'll probably see modal selects appear officially in the future, but for now this PR will no longer work (merge conflicts aside).

NeloBlivion avatar Aug 19 '22 09:08 NeloBlivion

On hold till modal selects are released. @Lulalaby Select Menus in modals have been implemented publicly

Nzii3 avatar Oct 13 '22 22:10 Nzii3

On hold till modal selects are released. @Lulalaby Select Menus in modals have been implemented publicly

Are you confusing this with the new select menus? To my knowledge they haven't released selects in modals yet.

plun1331 avatar Oct 13 '22 23:10 plun1331

It isn't available for modals. Pr still on hold!

Lulalaby avatar Oct 14 '22 00:10 Lulalaby

On hold till modal selects are released. @Lulalaby Select Menus in modals have been implemented publicly

Are you confusing this with the new select menus? To my knowledge they haven't released selects in modals yet.

Yeah my bad I realized they are different things

Nzii3 avatar Oct 16 '22 04:10 Nzii3