technology-data icon indicating copy to clipboard operation
technology-data copied to clipboard

Organic Rankine Cycle Data

Open LukasFrankenQ opened this issue 2 years ago • 7 comments

Adds data for Organic Rankine Cycles (ORC), and moves some data previously assigned to Enhanced Geothermal to ORC, to make things more clear.

Potentially has some overlap with data on waste or biomass, but the literature suggests this type of ORC operating around ~150 C is mostly used in a geothermal context, so it appears to warrant a separate technology. The implicit assumption of operating temperatures is stated clearly.

Also fixes a typo in the PR template.

Checklist

  • [x] Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • [x] Data source for new technologies is clearly stated.
  • [x] Newly introduced dependencies are added to environment.yaml (if applicable).
  • [x] A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • [x] I consent to the release of this PR's code under the GPLv3 license.

LukasFrankenQ avatar Nov 12 '23 18:11 LukasFrankenQ

Many thanks for the review @euronion, will amend!

LukasFrankenQ avatar Nov 13 '23 14:11 LukasFrankenQ

Hey @euronion, I moved everything to manual_input.csv, including geothermal, and think all of your points should be addressed...

... EXCEPT the changes in offshore wind, which I frankly do not understand - clearly nothing in relation to that is changed in the code. I have double checked my env, re-ran the script etc. it seems to persist. Checking the the files on github in outputs/ leaves me even more confused, as a Ctrl+F reveals they have no mention of offwind-float, which are claimed to exist by the 'Files Changed' tab of this PR.

What do you propose?

LukasFrankenQ avatar Nov 26 '23 13:11 LukasFrankenQ

Thanks @LukasFrankenQ !

Regarding offwind-float, it looks like @p-glaum did not regenerate the output files after moving the inputs from inputs/costs_PyPSA.csv to inputs/manual_input.csv in #108 , and so the inflation adjustment was not applied. So nothing you to avoid it. I have updated the master branch, if you merge it with your PR the changes should go away.

Can you also remove the clutter in inputs/manual_input.csv from changing many XX to XX.0 numbers? Then it will be easier to review and also understand / spot mistakes in the future based on the commit log. Thanks :)

euronion avatar Nov 30 '23 09:11 euronion

Alright, should be all set, thanks for research with regards to the wind.

There seems to be a new issue here, should this be adjusted? Seems less straightforward which version is better...

LukasFrankenQ avatar Dec 18 '23 17:12 LukasFrankenQ

Thanks! Much easier to review now :)

euronion avatar Dec 19 '23 07:12 euronion

Hey @euronion, I made the suggested changes, sorry for the delay! Let me know what you think :)

LukasFrankenQ avatar Jan 09 '24 09:01 LukasFrankenQ

Hi @euronion, apologies for the delay, worked in the feedback! Let me know if there is anything else 🙌

LukasFrankenQ avatar Feb 06 '24 14:02 LukasFrankenQ