setuptools-rust icon indicating copy to clipboard operation
setuptools-rust copied to clipboard

release: 1.10.0

Open davidhewitt opened this issue 1 year ago • 3 comments

davidhewitt avatar Jul 01 '24 15:07 davidhewitt

I'm concerned that #429 is going to break cryptography's build.

https://github.com/pyca/cryptography/blob/main/src/rust/cryptography-cffi/build.rs#L29-L37

This relies on running in the same venv where the build requirements were installed, because that Python script imports cffi.

Not sure if there's a way to write that script that's compatible with this change (which seems quite deserirable!)

alex avatar Jul 02 '24 00:07 alex

Hmm, good point. I think in general the fact that #429 is unconditionally breaking build isolation seems problematic

cc @messense; might also be a problem for maturin?

Not sure what to do here, the obvious solution is to revert #429 but maybe there's a better solution as you say. Avoiding needless recompilation would be great. Probably we have to move towards PYO3_ENVIRONMENT_SIGNATURE like maturin does.

Either way, setuptools-rust ran fine on 3.13 without changes so holding up the release a little bit while we work this out isn't going to block 3.13 testing.

davidhewitt avatar Jul 02 '24 07:07 davidhewitt

cc @messense; might also be a problem for maturin?

yes, we've got a report in maturin related to this, I've changed it to require setting a env var to opt-in the behavior in https://github.com/PyO3/maturin/pull/2134

messense avatar Jul 02 '24 07:07 messense

Ok, I think this should be better now with #458 merged.

davidhewitt avatar Aug 02 '24 22:08 davidhewitt

Sounds great.

alex avatar Aug 02 '24 22:08 alex

This is now live 👍

davidhewitt avatar Aug 03 '24 08:08 davidhewitt