rust-numpy icon indicating copy to clipboard operation
rust-numpy copied to clipboard

Bump py03

Open alexespencer opened this issue 1 year ago • 2 comments

Bumps py03 to 0.22.0

https://github.com/PyO3/pyo3/releases/tag/v0.22.0

alexespencer avatar Jun 25 '24 08:06 alexespencer

Looks like a number of changes will be needed, including PyNativeType being behind the py03 feature gil-refs, as well as changes to calls like as_borrowed(). Will try to spend some time researching this (simultaneously new to rust + pyo3) so would appreciate pointers

alexespencer avatar Jun 25 '24 09:06 alexespencer

Looks like a number of changes will be needed, including PyNativeType being behind the py03 feature gil-refs, as well as changes to calls like as_borrowed(). Will try to spend some time researching this (simultaneously new to rust + pyo3) so would appreciate pointers

Because PyNativeType is not available without the gil-refs feature you should implement all methods for Bound<Self> instead of &Self.

bschoenmaeckers avatar Jun 27 '24 07:06 bschoenmaeckers

Closing in favour of #431

alexespencer avatar Jul 02 '24 08:07 alexespencer