pylabrobot icon indicating copy to clipboard operation
pylabrobot copied to clipboard

Return Hamilton Heater Cooler via STAR control (accidentally deleted during HHS update)

Open BioCam opened this issue 8 months ago • 4 comments

BioCam avatar May 28 '25 16:05 BioCam

the specific code:

https://github.com/PyLabRobot/pylabrobot/pull/465/files#diff-8e948ee0472349094655029ed7795eb4e8a6d77b1556b4a1bbff922c12b17724L7150

rickwierenga avatar May 28 '25 20:05 rickwierenga

looking at the firmware interfaces, they appear almost identical.

changes i can identify:

  • shaking / locking on HHS
  • tb and tc on HHC
    • these actually also exist on the HHS but is not implemented:
Parameter  | Range        | Default | Description
-----------|--------------|---------|--------------------------------------------------------
ta####     | 0000..1150   | 0250    | Target temperature [1/10 °C]
tb####     | 0001..3600   | 1800    | Timeout until starting of temperature supervision [s]
tc####     | 0000..1150   | 0020    | Tolerance for temperature supervision [1/10 °C]
td####     | 0000..1150   | 0060    | Security tolerance for temperature supervision [1/10 °C]
te####     | 0000..1150   | 0150    | Offset for hardware security temperature [1/10 °C]

questions:

  • do the HHS and/or HHC have active cooling?
  • in terms of the firmware API, do you know if the HHS is a strict superset of HHC?

rickwierenga avatar May 28 '25 20:05 rickwierenga

HHS has no active cooling

HHC definitely has active cooling

In terms of firmware I don't know, one has shaking, the other doesn't while one has cooling and the other doesn't

BioCam avatar May 28 '25 21:05 BioCam

i propose adding back the accidentally removed HHC changes because there is no better current API. In the future, we should merge the HHS and HHC implementations as best we can and probably follow a similar model as we did with the HHS.

rickwierenga avatar May 28 '25 21:05 rickwierenga