Pyverilog icon indicating copy to clipboard operation
Pyverilog copied to clipboard

fix: unexpected keyword argument `reorder`

Open superpung opened this issue 2 years ago • 4 comments

In the definition of the VerilogGraphGenerator class, one of the arguments of its generate method is do_reorder: https://github.com/PyHDI/Pyverilog/blob/81838bc463d17148ef6872af34eb27585ee349ba/pyverilog/dataflow/graphgen.py#L57 However, in the example_graphgen.py file, this argument is mistakenly referred to as reorder. https://github.com/PyHDI/Pyverilog/blob/81838bc463d17148ef6872af34eb27585ee349ba/examples/example_graphgen.py#L100-L101 So when running python3 pyverilog/examples/example_graphgen.py -t top -s top.led test.v, I encountered error messages that are as follows:

Generating LALR tables
WARNING: 183 shift/reduce conflicts
Traceback (most recent call last):
  File "/path/to/pyverilog-demo/pyverilog/examples/example_graphgen.py", line 107, in <module>
    main()
  File "/path/to/pyverilog-demo/pyverilog/examples/example_graphgen.py", line 100, in main
    graphgen.generate(target, walk=options.walk, identical=options.identical,
TypeError: VerilogGraphGenerator.generate() got an unexpected keyword argument 'reorder'

superpung avatar May 15 '23 12:05 superpung

Fixes #97 and #117.

8ware avatar Aug 13 '24 15:08 8ware

Bug has been introduced in commit 7086786a6f5f8ad965b097344a77b4b86d21a93c.

8ware avatar Aug 13 '24 15:08 8ware

/cc @shtaxxx

superpung avatar Aug 14 '24 05:08 superpung

@shtaxxx

barnard33-233 avatar Sep 12 '24 13:09 barnard33-233