pyfilesystem
pyfilesystem copied to clipboard
PyFilesystem
Patch to support pyftpdlib 1.0.0
Current code is based on 0.7.0 version.
It should still work but it will raise different deprecation warnings due to
backward incompatible changes introduced in 1.0.0 version:
https://groups.google.com/forum/?fromgroups=#!topic/pyftpdlib/DlU0N8LkS38
The patch in attachment fixes them.
Original issue reported on code.google.com by g.rodola on 17 Apr 2013 at 2:20
Attachments:
Updated patch absent junk.
Original comment by g.rodola on 17 Apr 2013 at 2:31
Attachments:
I guess as pyftpdlib 1.0.0 now supports Python 3, the "not PY3" ImportError
could be removed too? (Or be modified to say "needs pyftpdlib >= 1.0.0")
And then __test__ would additionally need to depend on which version of
pyftpdlib was imported.
P.S. Nice to see you here Giampaolo :)
Original comment by [email protected] on 17 Apr 2013 at 10:08
Yes, I suppose that can be safely removed.
Please note that I have not extensively tested this.
1.0.0 version of pyftpdlib has a filesystem class which now expects Unicode
instead of bytes and that is explicitly assert-ed in the code.
FWICT I ran fs/tests/test_ftpfs.py, then connected with an FTP client and
successfully listed a directory.
It looks like it works, but you know...
> P.S. Nice to see you here Giampaolo :)
Thanks. =)
Original comment by g.rodola on 17 Apr 2013 at 10:33
Feel free to apply that, Andrew! Agree re Python 3 support.
Original comment by willmcgugan on 17 Apr 2013 at 10:53
IIRC test_ftpfs.py only checks the fs/ftpfs.py code (i.e. 'FTP client' mode),
AFAIK there's not yet any tests for fs/expose/ftp.py (i.e. 'FTP server' mode).
Original comment by [email protected] on 17 Apr 2013 at 10:56
Original comment by g.rodola on 17 Apr 2013 at 5:46
Attachments: