pycodestyle icon indicating copy to clipboard operation
pycodestyle copied to clipboard

Edges appending to only one instance of Svelvet container

Open gonzaloaune opened this issue 1 year ago โ€ข 4 comments

Description

If you have more than one Svelvet app container and you have Edges on your Nodes, the Edges are only appended to the first instance of the Svelvet app due to this line https://github.com/open-source-labs/Svelvet/blob/bd69dc3c6b0393569fe62caa766928c90065905a/src/lib/components/Edge/Edge.svelte#L20

Reproduction

https://stackblitz.com/edit/vitejs-vite-3df9v8?file=package.json,src%2FApp.svelte

  1. Create 2 instances of Svelvet apps with Edges, Anchors and Nodes
  2. See the first one will have double the Edges
  3. See the subsequent instances of Svelvet apps not drawing the Edges

System information

svelte: ^4.2.12 => 4.2.12
svelte-loader: ^3.2.0 => 3.2.0
svelvet: 10.0.2 => 10.0.2

Additional information

No response

๐Ÿ‘จโ€๐Ÿ‘งโ€๐Ÿ‘ฆ Contributing

  • [ ] ๐Ÿ™‹โ€โ™‚๏ธ Yes, I'd love to make a PR to fix this bug!

gonzaloaune avatar Jul 11 '24 14:07 gonzaloaune

Hi @gonzaloaune I can help with this

Khaalid-oh avatar Jul 13 '24 08:07 Khaalid-oh

I can't seem to reach you on sphinx chat. This is my sphinx id on the community @Saif

Khaalid-oh avatar Jul 13 '24 08:07 Khaalid-oh

#515

turizspace avatar Jul 14 '24 08:07 turizspace

HI @gonzaloaune, this issue is available then please assign me?

aliraza556 avatar Jul 17 '24 10:07 aliraza556