meaning script error on 3.7

[bbelderbos]

Hey @rhyspowell any idea why meaning.py fails only on 3.7?

https://github.com/PyBites-Open-Source/pybites-tools/actions/runs/3948290311/jobs/6758111574

Thanks, Bob

[rhyspowell]

@bbelderbos Looks like it just couldnt connect. ! of three things in my mind 1 The site was down for some reason 2 They possibly blocked us due to hitting so many times 3 There is something wrong with the urllib3 package on windows python 3.7

I'm somewhere between 1 or 2 but I cant see the button to force it to run again

[bbelderbos]

Why force the run again? Did you change anything?

I would think 3 possibly, the other versions / combinations are working.

But also, do we care about 3.7 at this point? I am happy to drop it from the matrix.

[rhyspowell]

force the run again to see if it is a load issue.

I would also say that we do still need to give 3.7 love as its still the only option in certain environments

[bbelderbos]

force the run again to see if it is a load issue.

I would also say that we do still need to give 3.7 love as its still the only option in certain environments

You were right, re-run did it: https://github.com/PyBites-Open-Source/pybites-tools/actions/runs/3948290311 🎉

[bbelderbos]

@rhyspowell Windows seems to fail pretty consistently, although now it failed on 3.9: https://github.com/PyBites-Open-Source/pybites-tools/actions/runs/4112579644 - I am rerunning the failed job.

[rhyspowell]

that might suggest some rate limiting then. It looks to pass as soon as you rerun it?

[bbelderbos]

Yep rerun passed so yeah might be rate limiting ...

[rhyspowell]

ok, not sure when I will get time but might be worth looking at splitting the tests, most hit a mock endpoint so we are just testing the functionality of the app, one test will hit the real end point to test the functionality of the service and app integration, less unit and more functional

Thoughts?

[bbelderbos]

That would be a cool exercise / experiment, thanks.