PyZombis icon indicating copy to clipboard operation
PyZombis copied to clipboard

added external api to replace failing api

Open shivamshan opened this issue 3 years ago • 1 comments

Signed-off-by: Shivam Shandilya [email protected]

Summary

This PR replaces the failing University API with a working API that uses https and returns names of cities.

  • the cities of a particular country can be returned
  • this configuration can make the exercise more subjective for the users
  • modified pytest file of Hangman exercise to accommodate for new API
  • updated the concerning cassette

This PR thus closes #197

Checklist

  • [x] Variables, functions and comments are translated to Spanish
  • [x] Functions follow underscore notation
  • [x] Spell check done & typos fixed
  • [x] All python code is PEP8 compliant
  • [x] Test coverage with Playwright implemented; locators are Python code
  • [x] Reviewers assigned (all peers & at least 1 mentor)

Screenshot

new

shivamshan avatar Feb 08 '22 20:02 shivamshan

@reingart Hi, could you review this PR and suggest any changes if required?? Concerned Issue:- #197

shivamshan avatar Feb 23 '22 02:02 shivamshan