moonbeam-docs icon indicating copy to clipboard operation
moonbeam-docs copied to clipboard

Adding pallet xcm interface precompile

Open wuzhong-papermoon opened this issue 1 year ago • 1 comments

Description

Adding XCM interface precompile

Checklist

  • [ ✔️] I have added a label to this PR 🏷️
  • [ ✔️] I have run my changes through Grammarly
  • [ ✔️] If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • [ ✔️] If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • [ ✔️] If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • [ ✔️] After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • [ ✔️] If images have been added, I have run the compress-images.py script to compress the images.
  • [ ✔️] If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • [ ✔️] If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • [ ] Will need to create PR in moonbeam-docs repo to remove images
  • [ ] Will need to create PR in moonbeam-docs repo to remove variables
  • [ ] Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • [ ] No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

wuzhong-papermoon avatar Jul 31 '24 13:07 wuzhong-papermoon

@eshaben Could you check if the file structure is correct?

wuzhong-papermoon avatar Jul 31 '24 13:07 wuzhong-papermoon

Looks good! Just some comments on the images:

  • The style guide mentions that arrows should not be used with steps. So you can remove the arrows anywhere you're using steps.
  • Are the steps 24x24px? This is also outlined in the style guide if you need more info
  • On xcm-interface-2.webp the steps appear to be larger than they are on xcm-interface-3.webp - can you tell me what size the steps are on 3? I can help you make some decisions here because I realize the size might need to change since they're so close together

As for the structure and where to put things, let me get back to you on this. But it will definitely need to be moved to the Interoperability > XCM section. I'll let you know where exactly!

Ah sorry that I didn't use standard style for steps. It should be all set now. 24x24 might be alright, would you take a look at the new images? @eshaben

wuzhong-papermoon avatar Aug 13 '24 08:08 wuzhong-papermoon

@wuzhong-papermoon yes, images look better! thanks!

eshaben avatar Aug 13 '24 18:08 eshaben