Federico Dolce
Federico Dolce
Talking about converting datetimes, I'm still making my mind about it, but I'm starting to have a clearer vision now. I think PyO3 should just represent datetimes as they are...
Ok, I should have addressed the last comments: - Added a comment on why we pass `None` to `utcoffset` - Added a test confirming that `ZoneInfo` is not converted to...
The CI fails on windows with this error: ``` ZoneInfoNotFoundError('No time zone found with key Europe/London'), ``` The reason is that windows does not offer a system IANA database: https://docs.python.org/3/library/zoneinfo.html#data-sources...
Great! Thanks everybody, this was really a team effort
I'm going to check what went wrong, where should I commit the fix? A separate branch and PR?
The test correctly crashes because I'm trying to initialize a FixedOffset with an out of bound value, but somehow running the proptest locally did not fail, so I missed this....
I opened #398 adding a `headers` option to the schema registry, that can be forwarded to all the requests there and be used for authentication
Yes, you can open a PR with the fix
Sure, feel free to open a PR with the fix
Just pushed a lot of commits that address all the comments. This is almost a full rewrite of the PR, but I think all the comments made sense and it...