linux-app icon indicating copy to clipboard operation
linux-app copied to clipboard

Consider supporting Ayatana app indicator

Open dlukes opened this issue 4 years ago • 3 comments

It looks like Ayatana is where new development of application indicator functionality is happening. On my distro (Solus), I managed to get the ProtonVPN GUI app indicator working with Ayatana with just this patch:

--- a/protonvpn_gui/view/indicator.py	2021-08-31 15:47:14.420742423 +0200
+++ b/protonvpn_gui/view/indicator.py	2021-08-31 15:47:33.515563589 +0200
@@ -103,8 +103,12 @@
     ERROR_PATH = os.path.join(ICON_DIR_PATH, VPN_TRAY_ERROR)
 
     def __init__(self, application):
-        gi.require_version("AppIndicator3", "0.1")
-        from gi.repository import AppIndicator3 as appindicator
+        try:
+            gi.require_version("AppIndicator3", "0.1")
+            from gi.repository import AppIndicator3 as appindicator
+        except ValueError:
+            gi.require_version("AyatanaAppIndicator3", "0.1")
+            from gi.repository import AyatanaAppIndicator3 as appindicator
         self.setup_reply_subject()
         self.__application = application
         self.__generate_menu()

Maybe worth upstreaming as a way of future-proofing the app as distros move towards Ayatana?

dlukes avatar Aug 31 '21 13:08 dlukes

Hey @dlukes

It is indeed a good suggestion. We'll look into it, thank you.

calexandru2018 avatar Aug 31 '21 14:08 calexandru2018

@dlukes, thank you for the solution!

@calexandru2018, are there any plans to implement this suggestion? As of today, ProtonVPN indicator does not function in Debian 11 by default.

To everyone, who stumbles across this thread. In Debian 11, one needs to implement the aforementioned change in: /usr/lib/python3/dist-packages/protonvpn_gui/view/indicator.py

mkmaslov avatar Apr 28 '22 11:04 mkmaslov