prometheus_client_php icon indicating copy to clipboard operation
prometheus_client_php copied to clipboard

Add Predis support

Open mtk3d opened this issue 8 months ago • 2 comments

Hi I've introduced changes to support Predis as an alternative Redis connection adapter, while maintaining full backward compatibility and avoiding code duplication. This was achieved by introducing a minimal RedisClient interface, designed according to the YAGNI principle. It only exposes the necessary methods required by the prometheus adapter. AbstractRedis.php is basically all redis generic logic moved from Redis.php

I know there already is a PR with predis but it seems abandoned. I see there is still need to have support for predis, also I need one for my project. So I decided to make this one, and I’m ready to help bring it across the finish line 😄

All tests are passing locally, and the code style checks are green, so I hope there will be no issues in pipeline.

mtk3d avatar Apr 30 '25 14:04 mtk3d

Ok, it's ready now

mtk3d avatar May 01 '25 11:05 mtk3d

Any updates about this? Could be really nice :)

HugoHeneaultDblc avatar Oct 02 '25 10:10 HugoHeneaultDblc