osrm.js icon indicating copy to clipboard operation
osrm.js copied to clipboard

Options not working

Open Ed-zo opened this issue 6 years ago • 2 comments

There seems to be some kind of problem when I'm trying to install this package using NPM. I found the problem. This method is missing a return keyword.

   _stringifyOptionsArray: function(array) {
         array.map(function(value) { return value === null && '' || value; }).join(';')
  },

This caused that options like sources or destinations were not added to the URL so they did not work. I looked at file on the github and the return is there. First I tought that I deleted it by a mistake and I didn't notice it but after I tried to install my project onto another machine the return was missing again. I don't mind the problem, I fixed it in my sources but if anybody else has problem with options not working have a look in the file src/osrm.js.

Ed-zo avatar Aug 28 '19 14:08 Ed-zo

@Ed-zo I ran into this as well and found that the bug was fixed in 2017 (https://github.com/Project-OSRM/osrm.js/pull/5). There just hasn't been an NPM release for quite a while.

jstrater avatar Feb 21 '20 18:02 jstrater