MAISI inference utility functions
Fixes # .
Description
MAISI inference utility functions
Checks
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the
./figurefolder - [ ] Notebook runs automatically
./runner.sh -t <path to .ipynb file>
Check out this pull request on ![]()
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
I'd like to outline a few points for consideration regarding the current PR:
- Should we present this tutorial using a bundle format, or would a Jupyter notebook or script be more user-friendly for understanding?
- It seems advantageous to generalize the
erode3d,dilate3d, andclosingfunctions and incorporate them into the MONAI core. - The augmentation methods added appear to diverge from the typical MONAI transform conventions. Would it be possible to align these new transforms with the established format? https://github.com/Project-MONAI/tutorials/blob/1c41a0cdaffe88665beffeb19eae282ef1fd4b74/generative/maisi/scripts/augmentation.py#L368
- I recommend removing the hard-coded label classes from functions when the operations are applicable across various datasets, promoting flexibility. https://github.com/Project-MONAI/tutorials/blob/1c41a0cdaffe88665beffeb19eae282ef1fd4b74/generative/maisi/scripts/find_masks.py#L43
- Could we refactor the larger function into a set of smaller, reusable functions for clarity and ease of understanding? I appreciate your attention to these suggestions and look forward to the refinements. Thanks!
I would suggest to change from "generative" to "generation" or "3d_generation" following folder structures of other tutorials. @Can-Zhao
@guopengf Hi Pengfei, I saw you have defined a few plotting funcs in mask_augmentation_example.ipynb Do you think it would be better to move them to somewhere like scripts/utils_plot.py? So all the other notebooks can use those plot funcs. Thank you!
The CI premerge-notebooks indicates the installation of monai-generative fails
To fix the imports and CI errors, I would suggest to do the following:
!python -c "import monai" || pip install -q "monai-weekly[nibabel, tqdm]"
!python -c "import generative; print(generative.__version__)" || pip install -q "monai-generative"
To fix the imports and CI errors, I would suggest to do the following:
!python -c "import monai" || pip install -q "monai-weekly[nibabel, tqdm]" !python -c "import generative; print(generative.__version__)" || pip install -q "monai-generative"
Thank. It seems CI error still exists...I was wondering if you have any idea on how to fix it. Thank you!
It is very likely that the CI environment (V100 16G) cannot support the notebook testing because:
- insufficient memory
- lack of supported
xformersversion compiled for the right arch