MONAI icon indicating copy to clipboard operation
MONAI copied to clipboard

[WIP] add DiNTS bundle template for auto3d

Open dongyang0122 opened this issue 3 years ago • 3 comments

Signed-off-by: Dong Yang [email protected]

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Status

Ready/Work in progress/Hold

Types of changes

  • [x] Non-breaking change (fix or new feature that would not break existing functionality).
  • [ ] Breaking change (fix or new feature that would cause existing functionality to change).
  • [ ] New tests added to cover the changes.
  • [ ] Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • [ ] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • [ ] In-line docstrings updated.
  • [ ] Documentation updated, tested make html command in the docs/ folder.

dongyang0122 avatar Aug 09 '22 15:08 dongyang0122

Hi @dongyang0122 ,

Is the bundle in this PR similar to the DiNTS bundle in the model-zoo? In my simple mind, ideally, we should download a bundle from the model-zoo and use part of the components of it, then we don't need to re-implement any bundle in this Auto3D codebase, just implement the hybrid python workflow program here. And for the future extension, we only need to provide more suitable bundles in the model-zoo. What do you think? CC @wyli @mingxin-zheng

Thanks.

Nic-Ma avatar Aug 12 '22 03:08 Nic-Ma

It is similar with DiNTS bundle, but all config based trainers or evaluators will be replaced with Python scripts. Downloading from model zoo adds additional layers of complexity. And the bundle templates cannot be executed directly due to pre-defined placeholders, and it might requires updates in the future given different configuration logics. It is easier to maintain in as independent template. Once the bundle is generated, we can export it to model-zoo.

dongyang0122 avatar Aug 14 '22 02:08 dongyang0122

Hi @dongyang0122 ,

OK, I think it looks good to me as long as the config logic is in the model-zoo repo, even they are specific bundles. I just suggest don't define some bundles in the source code of Auto3D. For the regular bundles, in my simple mind, I know we replace the trainer & evaluator of the bundles, but in theory, we can use other components of the config, so we can parse the regular DiNTS bundle, right?

Thanks.

Nic-Ma avatar Aug 14 '22 14:08 Nic-Ma

Close as switched to the research contribution repo.

Thanks.

Nic-Ma avatar Sep 05 '22 07:09 Nic-Ma