4609 Add AUCMLoss

[JohnMasoner]

Fixes #4609

Description

This PR added the AUCMLoss

Status

Work in progress

Types of changes

• [x] Non-breaking change (fix or new feature that would not break existing functionality).
• [ ] Breaking change (fix or new feature that would cause existing functionality to change).
• [x] New tests added to cover the changes.
• [ ] Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• [x] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
• [ ] In-line docstrings updated.
• [ ] Documentation updated, tested make html command in the docs/ folder.

[Nic-Ma]

Hi @JohnMasoner ,

Thanks for your contribution here, do you still plan to complete this PR?

[JohnMasoner]

Hi @JohnMasoner ,

Thanks for your contribution here, do you still plan to complete this PR?

hi @Nic-Ma ,

Yeah, I've been catching up on work-related content lately, and I'll complete this PR when I'm done with my work.

Actually, you could close the PR if it's better for MONAI.

Mason

[Nic-Ma]

Cool, sounds good. I don't want to close this PR, just to sync the status and plan with you.

Thanks.

[JohnMasoner]

Hi @Nic-Ma ,

I'm very sorry for the messy look of this PR due to my missteps and lack of familiarity with git.

Actually, i finished the code, but i don't know how to make this PR clean. I'm really sorry.

Mason

[Nic-Ma]

Hi @KumoLiu ,

Could you please help @JohnMasoner figure out the pending issue? I think this PR is a good contribution to MONAI.

Thanks in advance.

[KumoLiu]

Hi @JohnMasoner, it seems monai/losses/aucm_loss.py this file is empty, did you forget to push it?

[KumoLiu]

After your new commit, maybe you can check the coding style to fix the flake8 error.

# optionally update the dependencies and dev tools
python -m pip install -U pip
python -m pip install -U -r requirements-dev.txt

# run the linting and type checking tools
./runtests.sh --codeformat

# try to fix the coding style errors automatically
./runtests.sh --autofix

[JohnMasoner]

Hi @KumoLiu ,

I made some changes to the code to make it pass the automated tests (mainly cuda and dep test). And passed the flake8, but it still has some problems, I think it may not be a issus with this PR ( by the flake8-py3 action details).

Can you please help me to see what else is issue?

Mason

[KumoLiu]

Hi @JohnMasoner, flake8 error seems like issue mentioned in https://github.com/Project-MONAI/MONAI/issues/4975. It had been fixed, you can just update your code. Could you please also signed off to fix DCO.

[JohnMasoner]

@KumoLiu ,

I seem to have made a mistake that I can't go back and I've introduced other people's commits. I am not familiar with the operation of git, does my wrong operation have any effect?

Mason

[KumoLiu]

@KumoLiu ,

I seem to have made a mistake that I can't go back and I've introduced other people's commits. I am not familiar with the operation of git, does my wrong operation have any effect?

Mason

Try git pull remote branch, please.