processmaker icon indicating copy to clipboard operation
processmaker copied to clipboard

Preventing nested queries when opening a request - PM4EH-222

Open paulosakamoto opened this issue 3 years ago • 0 comments

Issue & Reproduction Steps

The request was overflowing memory due to nested queries.

Solution

Refactor the initial query, using native features of Laravel, to reduce the number of queries, and later cache a collection of screens.

As $screen must be a new versioning instance, it must not be cached.

In request 143, the number of queries was reduced from 336 to 28, mitigating the problem.

How to Test

As an admin user, open a request (/requests/{request}) that contains tokens and screens. The displayed HTML should be exactly as it was before.

Related Tickets & Packages

Code Review Checklist

  • [ ] I have pulled this code locally and tested it on my instance, along with any associated packages.
  • [ ] This code adheres to ProcessMaker Coding Guidelines.
  • [ ] This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • [ ] This solution fixes the bug reported in the original ticket.
  • [ ] This solution does not alter the expected output of a component in a way that would break existing Processes.
  • [ ] This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • [ ] This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • [ ] This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • [ ] This ticket conforms to the PRD associated with this part of ProcessMaker.

paulosakamoto avatar Nov 10 '22 14:11 paulosakamoto