processmaker icon indicating copy to clipboard operation
processmaker copied to clipboard

FOUR-6594: Add Prettier to Core

Open mcraeteisha opened this issue 3 years ago • 1 comments

Issue

Ticket: FOUR-6594

Related to our implementation of ESLint, we need to add Prettier to Core.

Solution

Installed Prettier in Core. Set configs to allow Prettier to only indent inside of the resources folder.

How to Test

  1. Run npx eslint resources/js/admin in Core. You should get a list of errors, including errors from Prettier. (Note: Running npx eslint resources will take a while because of the large number of files in the resources folder.)

Related Tickets & Packages

  • FOUR-6060 | Implement Eslint in Core
  • FOUR-6057 | Story: As a Developer, I want to improve the developer experience so that we code better and faster

Code Review Checklist

  • [ ] I have pulled this code locally and tested it on my instance, along with any associated packages.
  • [ ] This code adheres to ProcessMaker Coding Guidelines.
  • [ ] This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • [ ] This solution fixes the bug reported in the original ticket.
  • [ ] This solution does not alter the expected output of a component in a way that would break existing Processes.
  • [ ] This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • [ ] This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • [ ] This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • [ ] This ticket conforms to the PRD associated with this part of ProcessMaker.

mcraeteisha avatar Aug 11 '22 16:08 mcraeteisha

NOTE: Hopefully the Eslint work gets merged soon #4461 which will make this PR really tiny

josechirivella avatar Aug 11 '22 16:08 josechirivella