node-minecraft-protocol icon indicating copy to clipboard operation
node-minecraft-protocol copied to clipboard

fix: use node-rsa for decryption for higher node compatibility

Open jacobk999 opened this issue 1 year ago • 1 comments

  • Uses node-rsa to decrypt shared secrets and tokens because RSA_PKCS1_PADDING is no longer supported in the latest node version
  • Fixes #1293

jacobk999 avatar Aug 21 '24 16:08 jacobk999

I wonder if this is still a problem or was fixed in Node.js, can you confirm latest node still doesn't work?

extremeheat avatar Oct 20 '24 12:10 extremeheat

cc @u9g can you can check if on latest node this still happens and it's fixed by this PR?

extremeheat avatar Nov 14 '24 06:11 extremeheat

Sorry, I kind of forgot about this PR but it is still necessary in node v23 image https://nodejs.org/api/crypto.html

jacobk999 avatar Jan 15 '25 16:01 jacobk999

/makerelease

rom1504 avatar Jan 19 '25 14:01 rom1504