PrismarineJS
1.19.0 support
With chat signing support
Todo
- Verify logic is correct for offline mode
Adds
- new client.signMessage and client.verifyMessage utility methods
- binary concatenation function (could possibly fit into protodef)
Need to handle offline mode on server also. I'm assuming server disables chat signing for the client if the server is in offline mode, maybe through setting hasVerifyToken to true. Need to investigate that, cc @rob9315
Passing. Should be possible to add some sort of test for the chat signing, but it's a bit tricky because that would involve a bit of boilerplate and patching mojang public key constant.
Hi !
When I try to login using this version from https://github.com/vincss/mcsleepingserverstarter, I got this error message :
And in my logs :
Chunk size is 848 but only 831 was read ; partial packet : {"name":"login_start","params":{"username":"Vincouille","signature":{"timestamp":[386,-1950364232],"publicKey":{"type":"Buffer","data":[48,130,1,34,48,13,6,9,42,134,72,134
Hope it helps !
@vincss
Are your dependencies up to date and are you using 1.19.0 (not 1.19.1) ? Sending an updated login packet allows my client to connect to an empty world
@vincss
Are your dependencies up to date and are you using 1.19.0 (not 1.19.1) ? Sending an updated login packet allows my client to connect to an empty world
I was on a 1.19.2, but indeed in 1.19 it's working better. Thanks.
ok looked at the code
looks good to me
I would appreciate if a few more people could try to boot it up and check everything seems to work for them
This doesn't update the README.md to include 1.19.0. Is that intentional or is that added with the next release PR?
No, please add it
On Wed, Aug 17, 2022, 17:02 Spencer Burgess @.***> wrote:
This doesn't update the README.md to include 1.19.0. Is that intentional or is that added with the next release PR?
— Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/node-minecraft-protocol/pull/1027#issuecomment-1218132384, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437RBCO6LN3YA4YSQUE3VZT5J5ANCNFSM546VNRWA . You are receiving this because you modified the open/close state.Message ID: @.*** com>