minecraft-data icon indicating copy to clipboard operation
minecraft-data copied to clipboard

Fixed 1.20.71 correctPlayerMovePredictionPacket missing `prediction_type`

Open Cdm2883 opened this issue 1 year ago • 7 comments

Cdm2883 avatar Apr 16 '24 16:04 Cdm2883

Can you apply this fix to previous versions where it's also applicable?

extremeheat avatar Apr 17 '24 20:04 extremeheat

Can you apply this fix to previous versions where it's also applicable?

The update to this packet structure seems to start in protocol 662, only 1.20.70+

Cdm2883 avatar Apr 18 '24 15:04 Cdm2883

Where are you seeing that? Seems like it should be applied since 1.20.40 (protocol v622)

https://github.com/Mojang/bedrock-protocol-docs/blob/main/html/svg/CorrectPlayerMovePredictionPacket.svg

extremeheat avatar Apr 19 '24 00:04 extremeheat

Where are you seeing that? Seems like it should be applied since 1.20.40 (protocol v622)

https://github.com/Mojang/bedrock-protocol-docs/blob/main/html/svg/CorrectPlayerMovePredictionPacket.svg

Sorry, I only noticed a change in the structure of the packet in protocol 662, so I may have made an incorrect subjective judgment without checking.

I'll try to try triggering the packet at previous versions of BDS later and then confirm the final situation.

Cdm2883 avatar Apr 19 '24 10:04 Cdm2883

should we merge this @extremeheat ?

rom1504 avatar Jul 26 '24 16:07 rom1504

should we merge this @extremeheat ?

I don't think this should be done at this time. I haven't freed up time to check previous versions lately, and then there's the fact that I've found more wrong in packets, and I'd like to continue fixing other packets on this PR :D

Should the status of this PR go to draft or something like that?

Cdm2883 avatar Jul 26 '24 16:07 Cdm2883

Up to you about the status, but thanks for clarifying!

rom1504 avatar Jul 26 '24 17:07 rom1504