SPEC icon indicating copy to clipboard operation
SPEC copied to clipboard

No macros lite

Open jonathanschilling opened this issue 3 years ago • 2 comments

This is a first step in removing macros in SPEC. The source remains to be cleaned up:

  • use -Wunused-variable gfortran option to see unused variables and remove them
  • use fprettify to ensure consistent formatting

jonathanschilling avatar Jul 07 '22 13:07 jonathanschilling

Hi, is there any progress on this? Sorry to revive a dead PR, but this kind of refactor would make it easier for somebody new to the codebase (like me) to understand the program and contribute 😇

missing-user avatar Nov 14 '24 19:11 missing-user

Hi, is there any progress on this? Sorry to revive a dead PR, but this kind of refactor would make it easier for somebody new to the codebase (like me) to understand the program and contribute 😇

Not since then - got stuck in certain other projects in the mean time. I would strongly support to continue this. Suggested steps:

  1. keep the setup as-is and adjust the code generators in macros to provide more-or-less readable code - check the auto-generated one
  2. once the auto-generated code looks fine, migrate the generated files to be the main source code files
  3. clean them up locally - remove unused using statements and dead variables

jonathanschilling avatar Nov 14 '24 20:11 jonathanschilling