autoupgrade icon indicating copy to clipboard operation
autoupgrade copied to clipboard
verified publisher icon PrestaShop

Disable the update button when the php version is not compatible

Open okom3pom opened this issue 4 years ago • 7 comments

Questions Answers
Description? Disable the update button when the php version is not compatible , Add Waring when a local archive is used , Add image php compatible version
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#25659 & Fixes PrestaShop/PrestaShop#25657
How to test? See below
Possible impacts? the module need an update for the next PrestaShop

  1. git clone https://github.com/PrestaShop/PrestaShop.git --branch 1.6.1.24 To have a possible update and a no comptaible php Version
  2. Install the module.
  3. Try to update with a non compatible php Version
  4. Use the local archive and see the warning
  5. Use a compatible PHP version and check no error.

You can use a another version of PrestaShop

Acutaly i use a constant, @marionf say to use a chanel from PrestaShop Api but he don't exist.

When an xml file is available on https://api.prestashop.com/xml/XXXX I can use it.

Capture d’écran de 2021-09-24 10-46-40 Capture d’écran de 2021-09-24 10-43-51 Capture d’écran de 2021-09-24 10-44-02

okom3pom avatar Sep 23 '21 10:09 okom3pom

Hello @okom3pom

Following your feedback, we decided to not prevent the upgrade if the version of PHP is not compatible with the version of PS to which the user wishes to upgrade. But rather to display a modal, in any case, to remind the user to check that his/her version of PHP is compatible with his/her PS version (current and the one he/she wants to upgrade)

Following your feedback, we have also updated the compatibility table as you can see below:

Capture d’écran 2021-10-08 à 14 47 37

We don't know the minimum and maximum versions of php compatible with the versions lower than 1.6.1.18, so we don't indicate them in the table.

The issues and mockups are now up to date.

Could you integrate these changes in your PR ?

marionf avatar Oct 08 '21 13:10 marionf

@matthieu-rolland you added "Waiting for dev" label, what do you need from maintainers ?

matks avatar Dec 23 '21 16:12 matks

I fixed the conflict but can't push on the PR for some reason I get permission denied, did you change the rights on your repo @okom3pom ?

matthieu-rolland avatar Jun 09 '22 13:06 matthieu-rolland

@matthieu-rolland tests are failing, probably because ??

kpodemski avatar Jul 05 '22 19:07 kpodemski

@khouloudbelguith your feedbacks have been addressed:

  1. fixed

  2. not reproduced, as seen with you

  3. not reproduced, as seen with you

  4. fixed

  5. fixed

  6. fixed

  7. fixed

  8. fixed

  9. If a recall correctly we don't intend to make this page mobile friendly

thank you !

matthieu-rolland avatar Jul 06 '22 17:07 matthieu-rolland

@okom3pom hey we hope to release the auto upgrade soon with some fix for the v8. I would be nice to have your PR :) Could you check @khouloudbelguith issues? 🚀

MatShir avatar Aug 29 '22 08:08 MatShir

@MatShir I think @matthieu-rolland took over this PR?

kpodemski avatar Aug 30 '22 21:08 kpodemski

Hello, since there was no new updates since 30 days, I think we should follow our guidelines and I'll close this pull request as it seems stale 😞

Don't worry: this doesn't mean this is over or this work is wasted. If at some point someone wants to solve https://github.com/PrestaShop/PrestaShop/issues/25659 and https://github.com/PrestaShop/PrestaShop/issues/25657 the commits in this PR can be fetched and the work continues. I did this in PR https://github.com/PrestaShop/PrestaShop/pull/29638 : I continued the work started in https://github.com/PrestaShop/PrestaShop/pull/28747.

So this work is not 'thrown into the void' 😉 .

Don't hesitate to ping me about this PR 😉

matks avatar Sep 30 '22 09:09 matks