LandR

LandR copied to clipboard

.createCohortData not doing what it says it does?

5

`.createCohortData` is supposed to (among other things) `message(blue("Set B to 0 where cover > 0 and age = 0, because B is least quality dataset")).` However this doesn't seem to...

CeresBarros

rename `BIOMOD_ModelingOptions` to `bm_ModelingOptions` following recent `biomod2` package update

2

biomod2 v4.2-5 [2024] renamed `BIOMOD_ModelingOptions()` to `bm_ModelingOptions()` I've made the changes in 9d4aeb93d1cb24f696fc65d1a1eaa12e4198951c on the `biomod2-updates` branch, but since we point to @CeresBarros fork of `biomod2` in the package Remotes,...

achubaty

table size is not a good predictor of algo performance in `vegTypeMapGenerator`

4

I noticed that for a table with 1340184 rows, turning assertions off in `vegTypeMapGenerator`, makes the function use algo == 2 : ``` Browse[2]> nrowCohortData [1] 1340184 Browse[2]> ## use...

CeresBarros

Pull in @tati-micheletti 's `makeLCCfromCohortData()` from https://github.com/tati-micheletti/caribouRSF_NT/blob/main/R/makeLCCfromCohortData.R Craig made a trimmed down (less flexible?) version here: https://github.com/ApexRMS/ROFSim/blob/main/makeLccFromCohortData_helper.R @josie-hughes and I want to use a common version that can be maintained...

achubaty

As pointed out in https://github.com/PredictiveEcology/Biomass_speciesData/issues/32#issuecomment-1285779794, `plotVTM` should ideally use `Plots` not `Plot`.

CeresBarros

using `$` to extract columns is dangerous due to partial matching. the wrong columns may inadvertently be extracted. ```r > library(data.table) > DT DT$col2 [1] "A" "B" "C" "D" "E"...

achubaty

because RColorBrewer palettes require minimum of 3

achubaty

this is already being done on travis (see lint bot comments on recent commits), but to run manually: ```r devtools::install_github("jimhester/lintr") library(lintr) lint_package() ```

achubaty

bug in dropTerm

2

reprex ``` repos

CeresBarros

reduce number of dependency packages

1

The recent addition of `Formula` to Imports (226886719465981cbbb3b6feb92a245b82e4de45) triggered the "too many dependency packages" NOTE during `R CMD check`. Should review the packages and remove the dependencies, or move them...

achubaty