New resource module : AppFabric
I work on a new resource for SharePoint DSC : Installation of Cumulative update for AppFabric : https://github.com/PowerShell/SharePointDsc/pull/394
This resource is not used only by sharepoint so, it will be interesting to create a new module with this resource and other like Installation of AppFabric binaries, start/stop service, manage configuration, etc..
Thanks in advance for your help.
Here you can find the Url of this new DSC module https://github.com/luigilink/AppFabricDsc
- [x] Ensure your new resource module is in its own public repository.
- [x] Ensure your new repository is under the MIT license.
- [x] Ensure your new resource module follows the High Quality DSC Resource Module Guidelines. I try the best I can :)
- [x] Set up a review pull request - Completed
- [x] Submit an issue in the main DSC Resource Kit repository with a link to your repository.
Can I have some help on "the empty branch" (PR review)?
Yes - did you read over the new resource module submissions page? If you're still running into specific issues on this, let me know.
Also, make sure it follows the uniform folder format as well as the other High Quality requirements
To be more closed to SharePointDsc and OfficeOnlineDsc, I copy/paste OfficeOnlineDsc and I adapt it for AppFabricDsc. So I have the same folders tree.
Impossible to merge dev or master in reviewBase: fatal: refusing to merge unrelated @histories
[Update]: I add the parameter allow-unrelated-histories git merge dev --allow-unrelated-histories
Review Pull Request: https://github.com/luigilink/AppFabricDsc/pull/6
What's the next step ?
It will need to be reviewed by the new module review team, but in the mean time, make sure it's following all of the High Quality requirements, as that will speed up the review process.
Are there still interest of adding the AppFabricDsc resource module to the DSC Resource Kit? If so I like to help getting this reviewed according to the new process of getting a resource module added to the DSC Resource Kit. I have opened an issue to update the text on How to do a new resource module submission, but basically if we gonna submit this resource module to DSC Resource Kit we need to make sure it follows the Quality Governance.
@luigilink are you still interested in linking your resource module to DSC Resource Kit? You will still keep it in your own repo. Let me know if you still want to do this and I will provide the steps to link it here. If you don't want to do this, then I suggest we close this issue. 🙂
@johlju Yes still interested. Tell me exactly what to do and I'll do it 😸
I have sent in a PR that adds the steps to do a new module submission, until that is accepted, please look here at the proposed texts.
New module submission: https://github.com/johlju/DscResources/blob/b899c99aa1cab6a481c060c26ab0db5e6e4d4d9c/NewResourceModuleSubmissions.md
Issue template: https://github.com/johlju/DscResources/blob/b899c99aa1cab6a481c060c26ab0db5e6e4d4d9c/.github/ISSUE_TEMPLATE/New_resource_module_submission.md
@luigilink have you thought anything more around this? Are you still interested so we should keep the issue open?