postleaf icon indicating copy to clipboard operation
postleaf copied to clipboard

instalation on subdirectory support added 1st stage

Open callingmybluff opened this issue 7 years ago • 3 comments

Pull Request Summary

This is the first stage into implementing the feature #90. This step replaces most static usage of root directory to an environment variable APP_LOCATION

However, with this PR, the feature is not done, and there are two issue I encountered and could not solve so far:

  • [x] When a url has a redirect, like login: /sub/admin/login?redirect=%2Fadmin will direct into /admin

  • [ ] resources from the upload directory "uploads" are links in the page to /uploads/... instead of /sub/uploads/....


All code contributions are subject to the terms of the Contributor License Agreement described in CONTRIBUTING.md.

callingmybluff avatar Jun 25 '18 20:06 callingmybluff

Thanks for submitting.

When a url has a redirect, like login: /sub/admin/login?redirect=%2Fadmin will direct into /admin

This may point you in the right direction.

resources from the upload directory "uploads" are links in the page to /uploads/... instead of /sub/uploads/....

I think the problem here is that the editor generates root-relative URLs. I'm not sure what side effects we'll incur by changing it to relative. It's worth experimenting with at least.

claviska avatar Jun 26 '18 03:06 claviska

I managed to do the redirect easily, but the images thing is a bit tough. I managed to change images in display while input, but that resulted in problems (storing wrong url probably?)

callingmybluff avatar Jun 26 '18 08:06 callingmybluff

I don't know if this is annoying. But I just want to say thank you, guys.

kylechine avatar Jul 01 '18 23:07 kylechine