posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix: Using "Save & continue editing" on a new insight doesn't redirect to /insights/<short_id>

Open gitstart opened this issue 3 years ago • 5 comments

Problem

Using "Save & continue editing" on a new insight doesn't redirect to /insights/<short_id> This should redirect the user to the edit page with the id of the newly saved insight in the url but it isn't currently

Changes

fixes #11049

before & after

Loom Video

Ref

How did you test this code?

gitstart avatar Sep 09 '22 13:09 gitstart

@Twixes, @benjackwhite, Ready for review

gitstart avatar Sep 09 '22 13:09 gitstart

@benjackwhite, Still up for review

gitstart avatar Sep 12 '22 10:09 gitstart

@benjackwhite, Changes have been addressed

gitstart avatar Sep 19 '22 12:09 gitstart

@Twixes, Ready for review

gitstart avatar Sep 19 '22 17:09 gitstart

Unfortunately this doesn't fix the core issue. This will indeed redirect but not to the correct place as it should redirect to the "edit" view and not the standard view.

This change so far just makes it behave as the usual save button

Should the test be updated to reflect this?

gitstart avatar Sep 20 '22 09:09 gitstart

Closing in favor of #12384.

Twixes avatar Oct 21 '22 12:10 Twixes