gobierto icon indicating copy to clipboard operation
gobierto copied to clipboard

Split plugins code in different engines

Open amiedes opened this issue 6 years ago • 2 comments

Right now the existing plugins are located in the same Rails engine. After discussing in the office we've decided to split them in one-engine per plugin, reasons are:

  • Keep plugins independent
  • Avoid having to install them for a client that does not need them

These plugins share both JS and Ruby code (for test helpers). In order to share this between them one idea was to create a gem, but it's open to other solutions.

In regard to frontend integration, each plugin implements a Vue component named <plugin_name>.vue. Move the plugins from app/javascript/gobierto_plans/plugins/*.vue to the vendor directory. plan_types_controller uses a relative path to load the plugins, keep that in mind.

amiedes avatar Jun 19 '19 17:06 amiedes

This should be done now? Please explain reasons to do this so no more explanation is needed.

furilo avatar Jun 20 '19 10:06 furilo

Issue updated to consider also moving the Vue components to the proper folder.

ferblape avatar Jul 03 '19 16:07 ferblape