`AsNodeRef` as currently implemented encourages problems, can insert node that is not local to the graph

Open fabianmurariu opened this issue 1 year ago • 1 comments

          `AsNodeRef` as currently implemented encourages problems as it means that if we use a node from a different graph to insert it into an existing graph, it will use the local id which is likely nonsense. We should fix this in `NodeRef` so it keeps the NodeView around when created from a node which now should allow us to check if the node is local to the graph or not and act accordingly.

Originally posted by @ljeub-pometry in https://github.com/Pometry/Raphtory/pull/1695#discussion_r1691361991

Jul 26 '24 09:07 fabianmurariu

Still happening

Dec 17 '24 10:12 fabianmurariu