polymath-core-deprecated icon indicating copy to clipboard operation
polymath-core-deprecated copied to clipboard

Missing check on registerOfferingFactory

Open sangheraio opened this issue 7 years ago • 1 comments

There should be a check to prevent duplicate registration of an offeringFactory.

sangheraio avatar Feb 22 '18 23:02 sangheraio

I think we are covering this by the check https://github.com/PolymathNetwork/polymath-core/blob/7413dbd27347b27c8923d762e8b17da7745cc9c3/contracts/Compliance.sol#L199-L200

Above check facilitate to put up the restriction on changing the offeringFactory reputation data. if the offering factory doesn't get proposed then it will be potentially opened for this duplicate registration and I think it doesn't affect our system. If we want to restrict this also then we need a mapping mapping(address => bool) registerdOfferingFactoryList to restrict any type of duplicate registrations.

satyamakgec avatar Feb 23 '18 06:02 satyamakgec