Merge PMArbitraryPrecisionFloatForTrigonometry with PMArbitraryPrecisionFloat

Open SergeStinckwich opened this issue 4 years ago • 4 comments

@nicolas-cellier-aka-nice why do we need a separate class only for sin, cos and pi for arbitrary precision floatPMArbitraryPrecisionFloatForTrigonometry? I think we can merge with PMArbitraryPrecisionFloat to avoid confusion.

Feb 28 '21 08:02 SergeStinckwich

Yes, good idea, the only thing to care of is the precision of pi used in the subclass.

Feb 28 '21 09:02 nicolas-cellier-aka-nice

Do you mind to do a PR with this modification? Thank you.

Feb 28 '21 09:02 SergeStinckwich

I've implemented upstream, see issue #199

Feb 28 '21 13:02 nicolas-cellier-aka-nice

ok thank you. I have to see how to see the changes between the upstream and the PM version.

Feb 28 '21 13:02 SergeStinckwich