PolyMC icon indicating copy to clipboard operation
PolyMC copied to clipboard
verified publisher icon PolyMC

Width of instance toolbar changes when instances with long names are selected

Open kthchew opened this issue 3 years ago • 0 comments

Operating System

macOS

Version of PolyMC

PolyMC 1.3.2

Description of bug

Selecting an instance with a long name can cause the width of the instance toolbar to increase. This is annoying because it may mean there is not enough space for all of the instances to stay in their current position, which causes all of the instance icons to shift. The toolbar should always remain the same width, and words should wrap around.

Screen Shot 2022-07-17 at 7 32 46 PM Screen Shot 2022-07-17 at 7 32 55 PM

Steps to reproduce

  1. Create an instance with a short name (e.g. "1.19")
  2. Create an instance with a long name (e.g. "Fabulously Optimized 1.19")
  3. Switch selection between the two instances and observe the sidebar

Suspected cause

Uncommenting this seems to resolve the issue.

https://github.com/PolyMC/PolyMC/blob/cd948dceaed4625e7a876f680d3dc028e6cfe6de/launcher/ui/widgets/LabeledToolButton.cpp#L59-L60

But why was this commented out in the first place? (Git points to https://github.com/PolyMC/PolyMC/commit/ea71281629706b4a8187108e4877b440e0e9b4df, but I'm not sure how to see whether that's still an issue.)

This issue is unique

  • [X] I have searched the issue tracker and did not find an issue describing my bug.

kthchew avatar Jul 17 '22 23:07 kthchew