policyengine-us icon indicating copy to clipboard operation
policyengine-us copied to clipboard

Update FY2025 and fix FY2024 SNAP parameters based on SNAP Screener

Open hua7450 opened this issue 1 year ago • 9 comments

Fixes #5115

hua7450 avatar Sep 26 '24 20:09 hua7450

Still a draft, detailed differences in this doc.

hua7450 avatar Sep 26 '24 21:09 hua7450

@hua7450 is this pr supposed to fix old values (FY 2023 and before) or update parameters with FY2024. If its the former, the dates should be fixed from 2024-10-01 to 2023-10-01 and if its the latter most of the states are missing updated values as shown in https://www.fns.usda.gov/snap/eligibility/deduction/standard-utility-allowances

vrathi101 avatar Oct 05 '24 16:10 vrathi101

@hua7450 is this pr supposed to fix old values (FY 2023 and before) or update parameters with FY2024. If its the former, the dates should be fixed from 2024-10-01 to 2023-10-01 and if its the latter most of the states are missing updated values as shown in https://www.fns.usda.gov/snap/eligibility/deduction/standard-utility-allowances

It’s the later. I have updated all the 2024 values in the utility folder. Those states that did not have 2024 values have the same values as they have in 2023. 

hua7450 avatar Oct 06 '24 06:10 hua7450

@hua7450 is this pr supposed to fix old values (FY 2023 and before) or update parameters with FY2024. If its the former, the dates should be fixed from 2024-10-01 to 2023-10-01 and if its the latter most of the states are missing updated values as shown in https://www.fns.usda.gov/snap/eligibility/deduction/standard-utility-allowances

It’s the later. I have updated all the 2024 values in the utility folder. Those states that did not have 2024 values have the same values as they have in 2023.

ok, in that case aren't you missing a ton of values, for example in water utilities: Alaska = 57, colorado = 69, delaware = 99, DC = 88, etc. or am I misunderstanding? I circled some examples but there are a bunch more Screenshot 2024-10-06 at 10 38 33 AM

vrathi101 avatar Oct 06 '24 15:10 vrathi101

@hua7450 is this pr supposed to fix old values (FY 2023 and before) or update parameters with FY2024. If its the former, the dates should be fixed from 2024-10-01 to 2023-10-01 and if its the latter most of the states are missing updated values as shown in https://www.fns.usda.gov/snap/eligibility/deduction/standard-utility-allowances

It’s the later. I have updated all the 2024 values in the utility folder. Those states that did not have 2024 values have the same values as they have in 2023.

ok, in that case aren't you missing a ton of values, for example in water utilities: Alaska = 57, colorado = 69, delaware = 99, DC = 88, etc. or am I misunderstanding? I circled some examples but there are a bunch more Screenshot 2024-10-06 at 10 38 33 AM

Yes, I will double-check and add more to it.

hua7450 avatar Oct 08 '24 18:10 hua7450

@vrathi101 I just checked, I think you are looking at the Excel sheet for FY 2025, USDA recently updated the Excel sheet for utility in October. That's why the values you see are different from mine. image

hua7450 avatar Oct 13 '24 23:10 hua7450

@vrathi101 I just checked, I think you are looking at the Excel sheet for FY 2025, USDA recently updated the Excel sheet for utility in October. That's why the values you see are different from mine. image

i see, my bad for that

vrathi101 avatar Oct 15 '24 16:10 vrathi101

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.10%. Comparing base (7808eef) to head (bb29cd1). Report is 350 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5146   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files        2801     2801           
  Lines       40527    40527           
  Branches      190      190           
=======================================
  Hits        40164    40164           
  Misses        328      328           
  Partials       35       35           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 22 '24 18:10 codecov[bot]

@PavelMakarchuk could you please review?

MaxGhenis avatar Dec 01 '24 02:12 MaxGhenis